Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Missing artifacts in "BuildInfo" when uploading identical artifacts with different target path #1552

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Fix: Missing artifacts in "BuildInfo" when uploading identical artifacts with different target path #1552

merged 3 commits into from
Jun 6, 2022

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Jun 1, 2022 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on:

@Or-Geva Or-Geva added the bug Something isn't working label Jun 1, 2022
@Or-Geva Or-Geva requested a review from eyalbe4 June 1, 2022 14:30
@Or-Geva Or-Geva changed the title Add artifactory tests Duplicate artifacts are counted by their paths instead of their names Jun 1, 2022
@Or-Geva Or-Geva temporarily deployed to frogbot June 6, 2022 06:11 Inactive
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Jun 6, 2022
@Or-Geva Or-Geva changed the title Duplicate artifacts are counted by their paths instead of their names Duplicate build-info's artifacts are counted by their paths instead of their names Jun 6, 2022
This was referenced Jun 6, 2022
Merged
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

What is Frogbot?

@Or-Geva Or-Geva added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Jun 6, 2022
@Or-Geva Or-Geva merged commit eea586a into jfrog:dev Jun 6, 2022
@Or-Geva Or-Geva changed the title Duplicate build-info's artifacts are counted by their paths instead of their names Fix: Missing artifacts in "BuildInfo" when uploading identical artifacts with different target path Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working safe to test Approve running integration tests on a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Or-Geva @eyalbe4